m/sdlamp2
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Replace build scripts with a Makefile

Browse Source 
Single Makefile supports native builds (pkg-config) and cross-compilation
(CROSS_COMPILE/PREFIX env vars). Fixes -Wformat-truncation and
-Wstringop-truncation warnings at -O2 by sizing current_file to match
audio_files (256) and replacing strncpy with snprintf.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Michael Smith
2026-02-13 11:54:36 +01:00
parent 2fd764f60f
commit cbe3d67132
6 changed files with 50 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/sdlamp2.c
View File

@@ -49,7 +49,7 @@ static SDL_bool paused = SDL_TRUE;
static Decoder decoder = {0};
static char audio_dir[512] = ".";
static char current_file[512] = "";
static char current_file[256] = "";
static char audio_files[MAX_FILES][256];
static int num_audio_files = 0;
static int current_file_index = 0;
@@ -111,8 +111,7 @@ static void save_position(const char* filename, double seconds) {
snprintf(lines[num_lines], sizeof(lines[0]), "%s\t%.2f", filename, seconds);
found = SDL_TRUE;
} else {
strncpy(lines[num_lines], line, sizeof(lines[0]) - 1);
lines[num_lines][sizeof(lines[0]) - 1] = '\0';
snprintf(lines[num_lines], sizeof(lines[0]), "%s", line);
}
num_lines++;
}
@@ -210,8 +209,7 @@ static void scan_audio_files(const char* dir) {
while ((entry = readdir(d)) != NULL && num_audio_files < MAX_FILES) {
if (entry->d_name[0] == '.') continue;
if (has_audio_extension(entry->d_name)) {
strncpy(audio_files[num_audio_files], entry->d_name, 255);
audio_files[num_audio_files][255] = '\0';
snprintf(audio_files[num_audio_files], sizeof(audio_files[0]), "%s", entry->d_name);
num_audio_files++;
}
}